Re: [kvm-unit-tests PATCH v2] x86: Halt on exit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13/05/19 11:58, Nadav Amit wrote:
> In some cases, shutdown through the test device and Bochs might fail.
> Just hang in a loop that executes halt in such cases. Remove the
> __builtin_unreachable() as it is not needed anymore.
> 
> Signed-off-by: Nadav Amit <nadav.amit@xxxxxxxxx>
> ---
>  lib/x86/io.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/x86/io.c b/lib/x86/io.c
> index f3e01f7..f4ffb44 100644
> --- a/lib/x86/io.c
> +++ b/lib/x86/io.c
> @@ -99,7 +99,11 @@ void exit(int code)
>  #else
>          asm volatile("out %0, %1" : : "a"(code), "d"((short)0xf4));
>  #endif
> -	__builtin_unreachable();
> +
> +	/* Fallback */
> +	while (1) {
> +		asm volatile("hlt" ::: "memory");
> +	}
>  }
>  
>  void __iomem *ioremap(phys_addr_t phys_addr, size_t size)
> 

Queued, thanks.

Paolo



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux