On Mon, 2019-03-25 at 14:42 -0500, Bjorn Helgaas wrote: > Use dev_printk() when possible to make messages consistent with other > device-related messages. trivial note: > diff --git a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c [] > @@ -89,7 +89,8 @@ static int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev) > } while ((pcs_value & MDIO_CTRL1_RESET) && --count); > > if (pcs_value & MDIO_CTRL1_RESET) > - pr_warn("%s XGBE PHY reset timeout\n", __func__); > + dev_warn(&vdev->device, "%s XGBE PHY reset timeout\n", > + __func__); Many of these could use a colon after the %s used with __func__ to make the output more consistent with other modules.