On Mon, 2009-06-29 at 03:08 -0700, Gleb Natapov wrote: > > - local_irq_save(flags); > mask_IO_APIC_setup(ioapic_entries); > - mask_8259A(); Is there a reason why the 8259 mask/unmask operations are separated from io-apic mask/unmask operations. Can we keep it together so that it will be easy to read and understand that we first do the interrupt subsystem mask, try enabling IR and x2apic and unmask the interrupt subsystem. Otherwise I am ok with this change. thanks, suresh -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html