Re: [PATCH kvmtool 4/9] disk/aio: Refactor AIO code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22/02/2019 16:37, Andre Przywara wrote:
> On Mon, 18 Feb 2019 13:06:57 +0000
> Jean-Philippe Brucker <jean-philippe.brucker@xxxxxxx> wrote:
> 
>> Move all AIO code to a separate file, disk/aio.c, to remove as much
>> #ifdefs as possible. Split the raw read/write disk ops into async and
>> sync, and choose which ones to use depending on CONFIG_HAS_AIO. Note that
>> we fix raw_image__close() which incorrectly checked CONFIG_HAS_VIRTIO
>> instead of CONFIG_HAS_AIO, and closed an unitialized disk->evt. A
>> subsequent commit will complete this refactoring by fixing use of the
>> 'async' disk attribute.
> 
> So I chased every function and line down from where it left to where it
> went, and it seems like a valid transformation to me.

Viewing the patch with "git show --color-moved" makes it a bit easier :)

>> Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@xxxxxxx>
> 
> Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>

Thanks!
Jean



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux