On 22/02/2019 16:38, Andre Przywara wrote: > On Mon, 18 Feb 2019 13:06:59 +0000 > Jean-Philippe Brucker <jean-philippe.brucker@xxxxxxx> wrote: > >> Currently when the kernel completes a batch of AIO requests and signals it >> via eventfd, we retrieve at most AIO_MAX events (256), and ignore the >> rest. Call io_getevents() again in case more events are pending. > > Did you encounter this case in a test or is this just theoretical? Only with a standalone test that exercised disk/aio.c. Through a guest it doesn't seems possible, since the virtio-blk queue currently has 256 slots (VIRTIO_BLK_QUEUE_SIZE), meaning at most 256 in-flight requests. That's currently equal to AIO_MAX, but it can easily be overlooked by someone changing one of the constants. > But I am just curious, the patch looks alright: > >> Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@xxxxxxx> > > Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx> Thanks! Jean
