On Fri, 11 Jan 2019 12:13:35 +1100 Alexey Kardashevskiy <aik@xxxxxxxxx> wrote: > > The words in TRACE_INCLUDE_PATH can be updated by C preprocessor defines. For > > example, if for some reason you had: > > > > #define pci special_pci > > > > The above would turn into: > > > > ../../drivers/vfio/special_pci > > > > and it wont build, and you will be left scratching your head wondering why. > > Lovely :) imho it is +1 for > CFLAGS_vfio_pci_nvlink2.o += -I$(src) > and a comment. A more realistic example is: #define pci 1 which I hit when I first tried to do it this way when I first implemented this code (not with "pci" but a similar word). I'll leave this up to the maintainers of the code to decide which way they want to do it, as they are the ones that have to deal with the fallout if something goes wrong ;-) -- Steve
