On Wed, Jan 09, 2019 at 07:22:50PM +0100, Christian Borntraeger wrote: > > On 09.01.2019 15:52, Michael S. Tsirkin wrote: > > On Wed, Jan 09, 2019 at 01:07:16PM +0100, Christian Borntraeger wrote: > >> On 09.01.2019 11:35, Wei Wang wrote: > >>> On 01/08/2019 04:46 PM, Christian Borntraeger wrote: > >>>> > >>>> On 08.01.2019 06:35, Wei Wang wrote: > >>>>> On 01/07/2019 09:49 PM, Christian Borntraeger wrote: > >>>>>> On 07.01.2019 08:01, Wei Wang wrote: > >>>>>>> virtio-ccw has deadlock issues with reading the config space inside the > >>>>>>> interrupt context, so we tweak the virtballoon_changed implementation > >>>>>>> by moving the config read operations into the related workqueue contexts. > >>>>>>> The config_read_bitmap is used as a flag to the workqueue callbacks > >>>>>>> about the related config fields that need to be read. > >>>>>>> > >>>>>>> The cmd_id_received is also renamed to cmd_id_received_cache, and > >>>>>>> the value should be obtained via virtio_balloon_cmd_id_received. > >>>>>>> > >>>>>>> Reported-by: Christian Borntraeger <borntraeger@xxxxxxxxxx> > >>>>>>> Signed-off-by: Wei Wang <wei.w.wang@xxxxxxxxx> > >>>>>>> Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx> > >>>>>>> Reviewed-by: Halil Pasic <pasic@xxxxxxxxxxxxx> > >>>>>> Together with > >>>>>> virtio_pci: use queue idx instead of array idx to set up the vq > >>>>>> virtio: don't allocate vqs when names[i] = NULL > >>>>>> > >>>>>> Tested-by: Christian Borntraeger <borntraeger@xxxxxxxxxx> > >>>>> OK. I don't plan to send a new version of the above patches as no changes needed so far. > >>>>> > >>>>> Michael, if the above two patches look good to you, please help add the related tested-by > >>>>> and reviewed-by tags. Thanks. > >>>> Can we also make sure that > >>>> > >>>> virtio_pci: use queue idx instead of array idx to set up the vq > >>>> virtio: don't allocate vqs when names[i] = NULL > >>>> > >>>> also land in stable? > >>>> > >>> > >>> You could also send the request to stable after it gets merged to Linus' tree. > >>> The stable review committee will decide whether to take it. > >>> > >>> Please see Option 2: > >>> > >>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > >>> > >> > >> Those patches are not upstream yet, Correct? > >> > >> Michael, > >> > >> can you add the stable tag before submitting? If not, can you give me a heads up when doing the > >> pull request so that I can ping the stable folks. > > > > Can you reply to patches that you feel are needed on stable with just > > > > Cc: stable@xxxxxxxxxxxxxxx > > > > in the message body? > > > > Then it's all automatically handled by ack attaching scripts. > > Done. But this only works if those patches are not already part of a tree. I guess they have to go via > your tree, correct? Yes. It works because I rebase my tree. -- MST
