On Wed, 31 Oct 2018 at 05:41, Junaid Shahid <junaids@xxxxxxxxxx> wrote: > > On 10/29/2018 02:39 AM, Wanpeng Li wrote: > > Interesting, I also implement a version of PTE D Bit based dirty > > logging 4 years ago w/o sending to upstream. The PTE D Bit based mode > > will switch to write protection mode each time before > > KVM_GET_DIRTY_LOG ioctl or just once before the xx_start? > > > > The switch to write-protection mode will be done only when userspace calls the KVM_SET_DIRTY_LOG_MODE IOCTL with KVM_DIRTY_LOG_MODE_WRPROT as the parameter. The general expectation is that userspace will call this only once near the end of the brownout period. If your "brownout period" is the time between previous get_dirty_log and next get_dirty_log and the "blackout" is get_dirty_log? Regards, Wanpeng Li
