On 2018-10-19 at 12:33:48 -0400, Barret Rhoden wrote: > On 2018-09-21 at 21:29 David Hildenbrand <david@xxxxxxxxxx> wrote: > > On 21/09/2018 20:17, Dan Williams wrote: > > > On Fri, Sep 21, 2018 at 7:24 AM David Hildenbrand <david@xxxxxxxxxx> wrote: > > > [..] > > >>> Remove the PageReserved flag sounds more reasonable. > > >>> And Could we still have a flag to identify it is a device private memory, or > > >>> where these pages coming from? > > >> > > >> We could use a page type for that or what you proposed. (as I said, we > > >> might have to change hibernation code to skip the pages once we drop the > > >> reserved flag). > > > > > > I think it would be reasonable to reject all ZONE_DEVICE pages in > > > saveable_page(). > > > > > > > Indeed, that sounds like the easiest solution - guess that answer was > > too easy for me to figure out :) . > > > > Just to follow-up, is the plan to clear PageReserved for nvdimm pages > instead of the approach taken in this patch set? Or should we special > case nvdimm/dax pages in kvm_is_reserved_pfn()? Yes, we are going to remove the PageReserved flag for nvdimm pages. Added Alex, attached the patch-set. > > Thanks, > > Barret > > >
--- Begin Message ---
- Subject: [mm PATCH v4 5/6] mm: Add reserved flag setting to set_page_links
- From: Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx>
- Date: Wed, 17 Oct 2018 16:54:31 -0700
- Cc: pavel.tatashin@xxxxxxxxxxxxx, mhocko@xxxxxxxx, dave.jiang@xxxxxxxxx, alexander.h.duyck@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, willy@xxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, yi.z.zhang@xxxxxxxxxxxxxxx, khalid.aziz@xxxxxxxxxx, rppt@xxxxxxxxxxxxxxxxxx, vbabka@xxxxxxx, sparclinux@xxxxxxxxxxxxxxx, dan.j.williams@xxxxxxxxx, ldufour@xxxxxxxxxxxxxxxxxx, mgorman@xxxxxxxxxxxxxxxxxxx, mingo@xxxxxxxxxx, kirill.shutemov@xxxxxxxxxxxxxxx
- Delivered-to: yi.z.zhang@xxxxxxxxxxxxxxx
- In-reply-to: <20181017235043.17213.92459.stgit@localhost.localdomain>
- References: <20181017235043.17213.92459.stgit@localhost.localdomain>
- User-agent: StGit/0.17.1-dirty
This patch modifies the set_page_links function to include the setting of the reserved flag via a simple AND and OR operation. The motivation for this is the fact that the existing __set_bit call still seems to have effects on performance as replacing the call with the AND and OR can reduce initialization time. Looking over the assembly code before and after the change the main difference between the two is that the reserved bit is stored in a value that is generated outside of the main initialization loop and is then written with the other flags field values in one write to the page->flags value. Previously the generated value was written and then then a btsq instruction was issued. On my x86_64 test system with 3TB of persistent memory per node I saw the persistent memory initialization time on average drop from 23.49s to 19.12s per node. Signed-off-by: Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx> --- include/linux/mm.h | 9 ++++++++- mm/page_alloc.c | 29 +++++++++++++++++++---------- 2 files changed, 27 insertions(+), 11 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 6e2c9631af05..14d06d7d2986 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1171,11 +1171,18 @@ static inline void set_page_node(struct page *page, unsigned long node) page->flags |= (node & NODES_MASK) << NODES_PGSHIFT; } +static inline void set_page_reserved(struct page *page, bool reserved) +{ + page->flags &= ~(1ul << PG_reserved); + page->flags |= (unsigned long)(!!reserved) << PG_reserved; +} + static inline void set_page_links(struct page *page, enum zone_type zone, - unsigned long node, unsigned long pfn) + unsigned long node, unsigned long pfn, bool reserved) { set_page_zone(page, zone); set_page_node(page, node); + set_page_reserved(page, reserved); #ifdef SECTION_IN_PAGE_FLAGS set_page_section(page, pfn_to_section_nr(pfn)); #endif diff --git a/mm/page_alloc.c b/mm/page_alloc.c index a0b81e0bef03..e7fee7a5f8a3 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1179,7 +1179,7 @@ static void __meminit __init_single_page(struct page *page, unsigned long pfn, unsigned long zone, int nid) { mm_zero_struct_page(page); - set_page_links(page, zone, nid, pfn); + set_page_links(page, zone, nid, pfn, false); init_page_count(page); page_mapcount_reset(page); page_cpupid_reset_last(page); @@ -1195,7 +1195,8 @@ static void __meminit __init_single_page(struct page *page, unsigned long pfn, static void __meminit __init_pageblock(unsigned long start_pfn, unsigned long nr_pages, unsigned long zone, int nid, - struct dev_pagemap *pgmap) + struct dev_pagemap *pgmap, + bool is_reserved) { unsigned long nr_pgmask = pageblock_nr_pages - 1; struct page *start_page = pfn_to_page(start_pfn); @@ -1231,19 +1232,16 @@ static void __meminit __init_pageblock(unsigned long start_pfn, * call because of the fact that the pfn number is used to * get the section_nr and this function should not be * spanning more than a single section. + * + * We can use a non-atomic operation for setting the + * PG_reserved flag as we are still initializing the pages. */ - set_page_links(page, zone, nid, start_pfn); + set_page_links(page, zone, nid, start_pfn, is_reserved); init_page_count(page); page_mapcount_reset(page); page_cpupid_reset_last(page); /* - * We can use the non-atomic __set_bit operation for setting - * the flag as we are still initializing the pages. - */ - __SetPageReserved(page); - - /* * ZONE_DEVICE pages union ->lru with a ->pgmap back * pointer and hmm_data. It is a bug if a ZONE_DEVICE * page is ever freed or placed on a driver-private list. @@ -5612,7 +5610,18 @@ static void __meminit __memmap_init_hotplug(unsigned long size, int nid, pfn = max(ALIGN_DOWN(pfn - 1, pageblock_nr_pages), start_pfn); stride -= pfn; - __init_pageblock(pfn, stride, zone, nid, pgmap); + /* + * The last argument of __init_pageblock is a boolean + * value indicating if the page will be marked as reserved. + * + * Mark page reserved as it will need to wait for onlining + * phase for it to be fully associated with a zone. + * + * Under certain circumstances ZONE_DEVICE pages may not + * need to be marked as reserved, however there is still + * code that is depending on this being set for now. + */ + __init_pageblock(pfn, stride, zone, nid, pgmap, true); cond_resched(); }
--- End Message ---
