On Fri, Sep 21, 2018 at 3:44 PM, Jim Mattson <jmattson@xxxxxxxxxx> wrote:
> This capability was never implemented. Aside from the #define, there
> are no references to it anywhere in the code base. Let's remove the
> misleading documentation.
>
> Signed-off-by: Jim Mattson <jmattson@xxxxxxxxxx>
> ---
> Documentation/virtual/kvm/api.txt | 4 +---
> include/uapi/linux/kvm.h | 2 +-
> tools/include/uapi/linux/kvm.h | 2 +-
> 3 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> index 647f94128a85..e15aaa460915 100644
> --- a/Documentation/virtual/kvm/api.txt
> +++ b/Documentation/virtual/kvm/api.txt
> @@ -834,7 +834,6 @@ struct kvm_clock_data {
> 4.31 KVM_GET_VCPU_EVENTS
>
> Capability: KVM_CAP_VCPU_EVENTS
> -Extended by: KVM_CAP_INTR_SHADOW
> Architectures: x86, arm, arm64
> Type: vcpu ioctl
> Parameters: struct kvm_vcpu_event (out)
> @@ -933,7 +932,6 @@ struct kvm_vcpu_events {
> 4.32 KVM_SET_VCPU_EVENTS
>
> Capability: KVM_CAP_VCPU_EVENTS
> -Extended by: KVM_CAP_INTR_SHADOW
> Architectures: x86, arm, arm64
> Type: vcpu ioctl
> Parameters: struct kvm_vcpu_event (in)
> @@ -955,7 +953,7 @@ KVM_VCPUEVENT_VALID_NMI_PENDING - transfer nmi.pending to the kernel
> KVM_VCPUEVENT_VALID_SIPI_VECTOR - transfer sipi_vector
> KVM_VCPUEVENT_VALID_SMM - transfer the smi sub-struct.
>
> -If KVM_CAP_INTR_SHADOW is available, KVM_VCPUEVENT_VALID_SHADOW can be set in
> +Beginning with the 2.6.35 kernel, KVM_VCPUEVENT_VALID_SHADOW can be set in
> the flags field to signal that interrupt.shadow contains a valid state and
> shall be written into the VCPU.
>
> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
> index 251be353f950..7fcbe0e60ec7 100644
> --- a/include/uapi/linux/kvm.h
> +++ b/include/uapi/linux/kvm.h
> @@ -836,7 +836,7 @@ struct kvm_ppc_resize_hpt {
> #define KVM_CAP_HYPERV_SPIN 46
> #define KVM_CAP_PCI_SEGMENT 47
> #define KVM_CAP_PPC_PAIRED_SINGLES 48
> -#define KVM_CAP_INTR_SHADOW 49
> +#define KVM_CAP_INTR_SHADOW 49 /* never implemented */
> #ifdef __KVM_HAVE_DEBUGREGS
> #define KVM_CAP_DEBUGREGS 50
> #endif
> diff --git a/tools/include/uapi/linux/kvm.h b/tools/include/uapi/linux/kvm.h
> index 07548de5c988..de03dfad207f 100644
> --- a/tools/include/uapi/linux/kvm.h
> +++ b/tools/include/uapi/linux/kvm.h
> @@ -836,7 +836,7 @@ struct kvm_ppc_resize_hpt {
> #define KVM_CAP_HYPERV_SPIN 46
> #define KVM_CAP_PCI_SEGMENT 47
> #define KVM_CAP_PPC_PAIRED_SINGLES 48
> -#define KVM_CAP_INTR_SHADOW 49
> +#define KVM_CAP_INTR_SHADOW 49 /* never implemented */
> #ifdef __KVM_HAVE_DEBUGREGS
> #define KVM_CAP_DEBUGREGS 50
> #endif
> --
> 2.19.0.444.g18242da7ef-goog
>
Ping.
