Re: [PATCH] kvm: vmx: Remove a mysterious FIXME

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 25, 2018 at 1:57 PM, Jim Mattson <jmattson@xxxxxxxxxx> wrote:
> Bits 63:32 of %rax and %rdx are cleared in handle_rdmsr, as they
> should be.  There is nothing here to fix.
>
> Signed-off-by: Jim Mattson <jmattson@xxxxxxxxxx>
> ---
>  arch/x86/kvm/vmx.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 06412ba46aa3..aba4780fbe82 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -7452,7 +7452,6 @@ static int handle_rdmsr(struct kvm_vcpu *vcpu)
>
>         trace_kvm_msr_read(ecx, msr_info.data);
>
> -       /* FIXME: handling of bits 32:63 of rax, rdx */
>         vcpu->arch.regs[VCPU_REGS_RAX] = msr_info.data & -1u;
>         vcpu->arch.regs[VCPU_REGS_RDX] = (msr_info.data >> 32) & -1u;
>         return kvm_skip_emulated_instruction(vcpu);
> --
> 2.19.0.605.g01d371f741-goog
>

Ping.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux