On Mon, Sep 10, 2018 at 06:15:10AM -0700, Sean Christopherson wrote: > Heh, that was the original formatting until I asked him to change it: > https://lkml.org/lkml/2018/8/29/809. Checkpatch throws an error if > there's a newline after 'Commit'. Though looking at this again, there > shouldn't be a colon after 'Commit' and there should be quotes inside > the parentheses, e.g. this satisfies checkpatch: Yeah, we don't take checkpatch too seriously - only when it makes sense to a human brain. Roughly speaking. In this case, the logic should be, the commit which is the culprit should be visible immediately. Although after the Fixes: tag thing got introduced, that argument is not as important anymore, I'd say. As to the formatting, I think adding this to your git config helps in that regard: [alias] ... one = show -s --pretty='format:%h (\"%s\")' so that you can do: $ git one 368a540e0232 368a540e0232 ("x86/kvmclock: Remove memblock dependency") -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --
