On Mon, 10 Sep 2018, Sean Christopherson wrote: > On Mon, 2018-09-10 at 14:04 +0200, Borislav Petkov wrote: > > On Fri, Sep 07, 2018 at 12:57:29PM -0500, Brijesh Singh wrote: > > > > > > Commit: 368a540e0232 (x86/kvmclock: Remove memblock dependency) > > > caused SEV guest regression. > > When mentioning a commit in the commit message, put it on a separate > > line, like this: > > > > "Commit > > > > 368a540e0232 (x86/kvmclock: Remove memblock dependency) > > > > caused a SEV guest regression." > > Heh, that was the original formatting until I asked him to change it: > https://lkml.org/lkml/2018/8/29/809. Checkpatch throws an error if > there's a newline after 'Commit'. Though looking at this again, there > shouldn't be a colon after 'Commit' and there should be quotes inside > the parentheses, e.g. this satisfies checkpatch: > > Commit 368a540e0232 ("x86/kvmclock: Remove memblock dependency") The whole 5 lines of 'commit bla broke' are bogus to me. They convey not really useful information and the commit line will repeat itself in the Fixes: tag. So something like: The recent removal of the memblock dependency caused a SEV guest regression because bla.... Fixes: 368a540e0232 ("x86/kvmclock: Remove memblock dependency") Is much more useful than the above independent of its formatting. Thanks, tglx
