Re: [PATCH 03/22] KVM: nVMX: Fail VMPTRLD when vmcs12 is shadow VMCS and nested CPU do not support VMCS shadowing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2018-06-27 08:48-0700, Jim Mattson:
> On Wed, Jun 27, 2018 at 8:35 AM, Radim Krčmář <rkrcmar@xxxxxxxxxx> wrote:
> 
> > Please change the name to nested_cpu_supports_vmx_shadow_vmcs().
> >
> > "nested_cpu_has" prefix is reserved for features that are enabled in VM
> > controls,
> 
> The current name was chosen to be consistent with the naming
> convention for tests of physical CPU capabilities, but I definitely
> prefer 'supports' to 'has.'
> 
> For consistency, can we also change the various cpu_has_vmx_*
> functions that test for physical cpu capabilities to
> cpu_supports_vmx_*?

Seems reasonable, but I thought there weren't any -- can you name an
example, thanks.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux