On Tue, Jun 12, 2018 at 12:18:03PM -0700, no-reply@xxxxxxxxxxx wrote: > Checking PATCH 1/2: kvm: support -realtime cpu-pm=on|off... > WARNING: line over 80 characters > #85: FILE: target/i386/kvm.c:1401: > + error_report("kvm: guest stopping CPU not supported: %s", strerror(-ret)); > > ERROR: do not initialise globals to 0 or NULL > #100: FILE: vl.c:145: > +bool enable_cpu_pm = false; > > total: 1 errors, 1 warnings, 82 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. We seem to violate this left and right. Let's drop this? -- MST