Re: [Qemu-devel] [PATCH v2 0/2] kvm: x86 CPU power management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180612184616.90838-1-mst@xxxxxxxxxx
Subject: [Qemu-devel] [PATCH v2 0/2] kvm: x86 CPU power management

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
>From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20180612184616.90838-1-mst@xxxxxxxxxx -> patchew/20180612184616.90838-1-mst@xxxxxxxxxx
Switched to a new branch 'test'
b92893898a i386/cpu: make -cpu host support monitor/mwait
26a0f862a2 kvm: support -realtime cpu-pm=on|off

=== OUTPUT BEGIN ===
Checking PATCH 1/2: kvm: support -realtime cpu-pm=on|off...
WARNING: line over 80 characters
#85: FILE: target/i386/kvm.c:1401:
+            error_report("kvm: guest stopping CPU not supported: %s", strerror(-ret));

ERROR: do not initialise globals to 0 or NULL
#100: FILE: vl.c:145:
+bool enable_cpu_pm = false;

total: 1 errors, 1 warnings, 82 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: i386/cpu: make -cpu host support monitor/mwait...
WARNING: line over 80 characters
#82: FILE: target/i386/kvm.c:371:
+            int disable_exits = kvm_check_extension(s, KVM_CAP_X86_DISABLE_EXITS);

total: 0 errors, 1 warnings, 60 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@xxxxxxxxxx




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux