Re: [PATCH 01/11] kvm: x86: Make sync_page() flush remote TLBs once only

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07.05.2018 18:19, Paolo Bonzini wrote:
> On 07/05/2018 11:22, David Hildenbrand wrote:
>>>  
>>> +/* Bits which may be returned by set_spte() */
>>> +#define WRPROT_SHADOW_PT	BIT(0)
>>> +#define NEED_FLUSH_REMOTE_TLBS	BIT(1)
>> Not sure if I really like returning flags. Especially as the naming does
>> not suggest that or that these values are somehow linked together.
>>
>> What about a flag &flush?
>>
> 
> I think the flags are okay (I dislike bool return values in general),
> but the naming can be improved, for example SET_SPTE_WRITE_PROTECTED and
> SET_SPTE_NEED_REMOTE_FLUSH.

The thing I don't like about flags is that you cannot properly handle
error scenarios anymore (return -EWHATEVER). But as there are no errors
scenarios to handle, fine with me :)

> 
> Paolo
> 


-- 

Thanks,

David / dhildenb



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux