2018-03-16 22:41 GMT+08:00 <no-reply@xxxxxxxxxxx>: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 1521211002-4529-1-git-send-email-wanpengli@xxxxxxxxxxx > Subject: [Qemu-devel] [PATCH] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] patchew/1521211002-4529-1-git-send-email-wanpengli@xxxxxxxxxxx -> patchew/1521211002-4529-1-git-send-email-wanpengli@xxxxxxxxxxx > t [tag update] patchew/20180315034507.6341-1-famz@xxxxxxxxxx -> patchew/20180315034507.6341-1-famz@xxxxxxxxxx > Switched to a new branch 'test' > 9ababe35bc i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS > > === OUTPUT BEGIN === > Checking PATCH 1/1: i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS... > WARNING: line over 80 characters > #52: FILE: target/i386/kvm.c:1003: > + int disable_exits = kvm_check_extension(cs->kvm_state, KVM_CAP_X86_DISABLE_EXITS); > > ERROR: line over 90 characters > #58: FILE: target/i386/kvm.c:1009: > + if (kvm_vm_enable_cap(cs->kvm_state, KVM_CAP_X86_DISABLE_EXITS, 0, disable_exits)) { > > total: 1 errors, 1 warnings, 36 lines checked I think it's fine, otherwise the format looks mess, anyway, please let me know if they still need to be less than 80 characters here. Regards, Wanpeng Li > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-devel@xxxxxxxxxxxxx
