On 14.03.2018 08:02, Janosch Frank wrote:
> On 13.03.2018 20:27, Thomas Huth wrote:
>> On 13.03.2018 13:01, Janosch Frank wrote:
>>> Let's add some tests for the diag10 "Release pages" instruction.
>>>
> [...]
>>> +int main(void)
>>> +{
>>> + report_prefix_push("diag10");
>>> + test_prefix();
>>> + test_params();
>>> + test_priv();
>>> + return report_summary();
>>> +}
>>> diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg
>>> index 8321e9b..5531590 100644
>>> --- a/s390x/unittests.cfg
>>> +++ b/s390x/unittests.cfg
>>> @@ -41,3 +41,6 @@ accel = kvm
>>>
>>> [skey]
>>> file = skey.elf
>>> +
>>> +[diag10]
>>> +file = diag10.elf
>>>
>>
>> Looks good to me!
>>
>> Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>
>
> Thanks!
>
>>
>> FWIW, the spec lists some more exceptions that could occur:
>>
>> Addressing exception The designated storage area includes discontinuous
>> storage.
>>
>> Protection exception The designated storage area includes read-only
>> storage.
>>
>> Worth a try to check them, too?
>
> Any idea on how to do that?
For the addressing exception, I guess you could try something like
diag10(0x7fffffffffffe000, 0x7ffffffffffff000) ?
> I guess the diag10.elf will have a readonly area that I could try to free.
I don't think that any ELF section will be marked as readonly in the
page tables, since the ELF loading is done by QEMU, not by our kernel.
So you'd likely need to mess with the page tables on your own... I guess
that's rather something for a later patch...
Thomas
Attachment:
signature.asc
Description: OpenPGP digital signature
