Re: [kvm-unit-tests PATCH 4/8] s390x: Add diag10 tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13.03.2018 20:27, Thomas Huth wrote:
> On 13.03.2018 13:01, Janosch Frank wrote:
>> Let's add some tests for the diag10 "Release pages" instruction.
>>
[...]
>> +int main(void)
>> +{
>> +	report_prefix_push("diag10");
>> +	test_prefix();
>> +	test_params();
>> +	test_priv();
>> +	return report_summary();
>> +}
>> diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg
>> index 8321e9b..5531590 100644
>> --- a/s390x/unittests.cfg
>> +++ b/s390x/unittests.cfg
>> @@ -41,3 +41,6 @@ accel = kvm
>>  
>>  [skey]
>>  file = skey.elf
>> +
>> +[diag10]
>> +file = diag10.elf
>>
> 
> Looks good to me!
> 
> Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>

Thanks!

> 
> FWIW, the spec lists some more exceptions that could occur:
> 
> Addressing exception  The designated storage area includes discontinuous
>                       storage.
> 
> Protection exception  The designated storage area includes read-only
>                       storage.
> 
> Worth a try to check them, too?

Any idea on how to do that?
I guess the diag10.elf will have a readonly area that I could try to free.

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux