On 13.02.2018 15:55, Paolo Bonzini wrote: > On 05/02/2018 14:00, Stefan Raspl wrote: >> From: Stefan Raspl <stefan.raspl@xxxxxxxxxx> >> >> Drilldown (i.e. toggle display of child trace events) was implemented by >> overriding the fields filter. This resulted in inconsistencies: E.g. when >> drilldown was not active, adding a filter that also matches child trace >> events would not only filter fields according to the filter, but also add >> in the child trace events matching the filter. E.g. on x86, setting >> 'kvm_userspace_exit' as the fields filter after startup would result in >> display of kvm_userspace_exit(DCR), although that wasn't previously >> present - not exactly what one would expect from a filter. >> This patch addresses the issue by keeping drilldown and fields filter >> separate. While at it, we also fix a PEP8 issue by adding a blank line >> at one place (since we're in the area...). >> We implement this by adding a framework that also allows to define a >> taxonomy among the debugfs events to identify child trace events. I.e. >> drilldown using 'x' can now also work with debugfs. A respective parent- >> child relationship is only known for S390 at the moment, but could be >> added adjusting other platforms' ARCH.dbg_is_child() methods >> accordingly. > > Looks good, but please name the functions "tracepoint_is_child" and > "debugfs_is_child" rather than "trc_is_child". Though I'd keep the names short - nevermind, will change. > Also, should "child_events" (and "pid" too) move from DebugfsProvider > and TracepointProvider up to "Provider"? Good point, will do. Ciao, Stefan
