On 01/25/2018 03:42 PM, David Hildenbrand wrote: > On 25.01.2018 15:32, Christian Borntraeger wrote: >> >> >> On 01/25/2018 03:20 PM, David Hildenbrand wrote: >> >>>> +void kvm_s390_gisa_init(struct kvm *kvm) >>>> +{ >>>> + if (1 || !css_general_characteristics.aiv) >>>> + kvm->arch.gisa = NULL; >>> >>> 1 || ... ? This will always trigger. -> gisa never active with this patch >> >> See patch 10. >> > > Well than this is just ugly this way. Reshuffling this is hard due to code dependencies. I can try to minimize this. The alternative is to merge patches 6,7,8,9 and 10, but this split makes it easier to review the parts.