On 19.01.2018 11:12, Heiko Carstens wrote: > On Thu, Jan 18, 2018 at 09:47:01PM +0100, David Hildenbrand wrote: >> Two minor things >> >>> >>> +struct kvm_s390_gisa { >>> + u32 next_alert; >>> + u8 ipm; >>> + u8 reserved01; >>> + u8:6; >> >> Mind giving this also a reserved name > > And then all reserved fields have to be renamed as soon as one bit gets > used? Please don't... > Only if one keeps the order of the reserved field numbers ... -- Thanks, David / dhildenb