On 27/12/2017 13:01, Liran Alon wrote: > I think that current patch series makes more sense than reordering them. > > This is because the patch you are suggesting will actually, as a > side-effect, fix the bug that is fixed in commit "KVM: nVMX: Deliver > missed nested-PI notification-vector via self-IPI while interrupts > disabled". This is actually the same as the first patch I suggested for > fixing the bug in v1 of this series: > http://lkml.kernel.org/r/1510252040-5609-1-git-send-email-liran.alon@xxxxxxxxxx > > After I submitted v1, Radim mentioned that even though the fix is > correct, it is awkward and error-prone. I agreed and therefore we have > written another fix using self-IPI. It's not exactly the same. My suggested version checks the return value of kvm_vcpu_trigger_posted_interrupt and calls kvm_vcpu_kick. > Therefore, to preserve each commit fixing only one problem, I prefer to > keep the orders of commits as they are now. It's true that it would hide the bug but it makes no sense to say you are fixing a bug in patch 9, and then fix that bug in the next patch. So I think this patch should definitely go first (in fact I'm tempted to install it together with patches 1-4...) and the rest should be done as a broader cleanup of vmx->nested.pi_pending. I agree with Radim that as of now it's awkward and needs some work. I was about to reply about that so I'll leave it for another email. Paolo
