On 27/12/17 11:56, Paolo Bonzini wrote:
On 24/12/2017 17:12, Liran Alon wrote:
- if (kvm_x86_ops->sync_pir_to_irr && apic->vcpu->arch.apicv_active)
+ if (apic->vcpu->arch.apicv_active)
highest_irr = kvm_x86_ops->sync_pir_to_irr(apic->vcpu);
else
highest_irr = apic_find_highest_irr(apic);
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index eb714f1cdf7e..99c42deb742b 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -4449,6 +4449,11 @@ static void svm_hwapic_isr_update(struct kvm_vcpu *vcpu, int max_isr)
{
}
+static int svm_sync_pir_to_irr(struct kvm_vcpu *vcpu)
+{
+ return -1;
+}
Shouldn't this be
return kvm_lapic_find_highest_irr(vcpu);
?
Paolo
Yes you are correct. My bad.
This would break apic_has_interrupt_for_ppr() in case apicv_active in
case of AMD SVM.
If there is more comments justifying a v4 series, I would fix it in that
series. Otherwise, could you just change this commit when applying?
Thanks,
-Liran
