On 22/10/2017 09:44, Christoffer Dall wrote: > However, I think it's much clearer if I > rewrite these to use get_user() and put_user(). v2 incoming. I'd actually prefer if you all do a trivial conversion to kvm_init_usercopy to begin with. In fact, we could just change the default from "0, 0" to "0, sizeof (kvm_arch_vcpu)" in kvm_init. Any other change can be applied after the patches are merged to Linus's tree, especially with KVM Forum and the merge window both coming soon. I'll send a v2 myself later this week. Thanks all, Paolo