----- Original Message ----- > From: "Radim Krčmář" <rkrcmar@xxxxxxxxxx> > To: "Paolo Bonzini" <pbonzini@xxxxxxxxxx> > Cc: "Peter Feiner" <pfeiner@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, "David Matlack" <dmatlack@xxxxxxxxxx> > Sent: Monday, July 3, 2017 7:13:44 PM > Subject: Re: [kvm-unit-tests PATCH 1/3] x86/vmx: fix EPT - MMIO access > > 2017-06-30 12:22+0200, Paolo Bonzini: > > On 29/06/2017 19:34, Peter Feiner wrote: > > > Reading the memory mapped page with x2apic is a bug. Use the generic > > > reader > > > instead. An alternative would be to disable x2apic. > > > > Disabling x2apic would test what the test is supposed to test. :) > > We should still be doing the same -- we're interested in testing the > MMIO access from the guest, which is being done in ept_main(). > > ept_init_common() is used just to access the reference value and I think > that allowing x2APIC there gives us a bit more leeway, Thanks for the explanation. You're obviously right, will apply tomorrow with an improved commit message. Paolo
