Re: [kvm-unit-tests PATCH 1/3] x86/vmx: fix EPT - MMIO access

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 29, 2017 at 10:26 AM, Radim Krčmář <rkrcmar@xxxxxxxxxx> wrote:
>
> Reading the memory mapped page with x2apic is a bug.  Use the generic reader
> instead.  An alternative would be to disable x2apic.
>
> Signed-off-by: Radim Krčmář <rkrcmar@xxxxxxxxxx>
Reviewed-by: Peter Feiner <pfeiner@xxxxxxxxxx>

> ---
>  x86/vmx_tests.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
> index 1f439522cad8..7be016ce4fbc 100644
> --- a/x86/vmx_tests.c
> +++ b/x86/vmx_tests.c
> @@ -1031,7 +1031,7 @@ static int ept_init_common(bool have_ad)
>         install_ept(pml4, (unsigned long)data_page1, (unsigned long)data_page2,
>                         EPT_RA | EPT_WA | EPT_EA);
>
> -       apic_version = *((u32 *)0xfee00030UL);
> +       apic_version = apic_read(APIC_LVR);
>         return VMX_TEST_START;
>  }
>
> --
> 2.13.2
>

Looks good!




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux