Re: [kvm-unit-tests PATCH] x86: fix ept_access_test_paddr exit qualifications

[Paolo Bonzini <pbonzini@xxxxxxxxxx>]

On 05/05/2017 22:57, David Matlack wrote:
>  static void ept_access_test_paddr_read_only_ad_disabled(void)
>  {
> -	u64 qual = EPT_VLT_WR | EPT_VLT_PERM_RD;
> +	u64 qual = EPT_VLT_WR | EPT_VLT_RD | EPT_VLT_PERM_RD;

So this patch *was* correct after all.  Sorry. :)

I've added a comment here and in
ept_access_test_paddr_read_execute_ad_disabled:

	/*
	 * When EPT AD bits are disabled, all accesses to guest paging
	 * structures are reported separately as a read and (after
	 * translation of the GPA to host physical address) a read+write
	 * if the A/D bits have to be set.
	 */

then squashed everything and pushed to kvm-unit-tests.git master branch.

Thanks again!

Paolo