Re: [PATCH v4] kvm: nVMX: Remove superfluous VMX instruction fault checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 27/04/2017 17:00, Jim Mattson wrote:
> On Thu, Apr 27, 2017 at 4:25 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>>
>>
>> On 27/04/2017 10:29, David Hildenbrand wrote:
>>>>  arch/x86/kvm/vmx.c | 55 ++++++++----------------------------------------------
>>>>  1 file changed, 8 insertions(+), 47 deletions(-)
>>> Nice! So we really only have to check vmxon / pointer / features for
>>> vmxon and for the others only vmxon.
>>
>> Still not good, CR4.VMXE has to be checked because we always run the
>> guest with CR4.VMXE set (see section 23.8 in the SDM).
> 
> Ah, yes, Of course.

I fixed this up and will push the patch briefly.

Paolo

>>
>> Paolo
>>
>>> Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
> 



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux