Yes, I agree. On Wed, Apr 26, 2017 at 2:26 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > > On 21/04/2017 18:53, Jim Mattson wrote: >> One of the constraints on the VMX instructions is that they are not >> allowed in real-address mode. Though the hardware checks for this >> condition as well, when real-address mode is emulated, the faulting >> condition does have to be checked in software. > > Emulated real mode is virtual-8086 mode, so that should be checked by > the processor too, right? > > VMX instructions are never called from the emulator, so they cannot be > reached from the emulate_invalid_guest_state path. And if they could, > you'd have to keep the CPL checks and all the others. So I think that > you can remove the checks for CR0.PE as well. > > Paolo
