2017-04-25 09:11+0200, Thomas Huth: > On 07.04.2017 15:49, Andrew Jones wrote: >> On Fri, Apr 07, 2017 at 03:16:57PM +0200, Thomas Huth wrote: >>> Many files in the lib folder do not have proper statements about >>> their license. Add such a header there so that it is clear under >>> which conditions the code can be used. >>> >>> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx> >>> --- >>> diff --git a/lib/argv.c b/lib/argv.c >>> @@ -1,3 +1,10 @@ >>> +/* >>> + * Set up arguments for main() and prepare environment variables >>> + * >>> + * This code is free software; you can redistribute it and/or modify it >>> + * under the terms of the GNU Library General Public License version 2. >>> + */ >>> + >>> #include "libcflat.h" >>> #include "auxinfo.h" >>> >> >> Reviewed-by: Andrew Jones <drjones@xxxxxxxxxx> > > *ping* (Sorry, I'll need to double-check all unit test patches from that time.) > Paolo, Radim, could you pick this up please if it sounds OK for you? It does, the licensing follows COPYRIGHT and I assume that we can't change the license without a lot of legal hassle. Took me a while to realize what isn't clear: libcflat.h is GPL 2 and being explicit with the border between GPL 2 and LGPL 2 sounds good for re-usability of the code. (I assume that the whole kvm-unit-tests is effectively GPL 2, but parts of it are more benevolent.) Applied, thanks.