2017-04-25 14:34+0200, David Hildenbrand: > On 25.04.2017 00:39, Steve Rutherford wrote: >> Sorry to resurrect this thread. There's an srcu_synchronize_expedited >> call in kvm_set_irq_routing, so this lock might get held for a fairly >> long while. Wouldn't it be a better idea to check the irqchip mode? >> > > We could maybe check for kvm->arch.irqchip_mode == KVM_IRQCHIP_NONE > here under lock instead of in the function itself. Maybe we then even > don't need patch NR 2. Will have a look! Sounds good and the extra mode would be obsolete. Checking in kvm_main.c will just need a new arch hook. The patches are already in kvm/next, though, so please prepare it as a fix. Thanks.