On 17.03.2017 12:11, Sergey Bronnikov wrote: > Hi, Thomas > > On 09:04 Fri 17 Mar , Thomas Huth wrote: >> On 17.03.2017 06:11, Sergey Bronnikov wrote: >>> On 08:38 Thu 16 Mar , Thomas Huth wrote: >>>> On 15.03.2017 11:25, Sergey Bronnikov wrote: >>>>> Some operating systems installs bash executable file to other directory >>>>> than /bin. So it is better to use env utility to find bash. >>>> >>>> Which operating systems do you have in mind here? >>> >>> OpenBSD >> >> Ok, then I'd say this patch simply does not make sense. We're talking >> about kvm-unit-tests here - and KVM is pretty much Linux-only as far as >> I know. > > according to description on the project page: > "Unit tests provide KVM and virtual hardware functional testing by > targeting the features through minimal implementations of their use per > the hardware specification." > http://www.linux-kvm.org/page/KVM-unit-tests > So testsuite is applicable to any virtual machine with hardware > emulation. OpenBSD has QEMU in ports and it's own hypervisor vmd(8) > (http://man.openbsd.org/vmd). It would be perfect to use testsuite > for regression testing of these hypervisors on OpenBSD too. > > Moreover my patch don't broke anything on Linux. Why not to commit it > and make tests more portable? OK, if you think that kvm-unit-tests is really usable on a non-Linux system this way, I'm fine with the change, too. I just wanted to make sure that this is more than just unnecessary code churn. Thomas
