Hi, Thomas On 09:04 Fri 17 Mar , Thomas Huth wrote: > On 17.03.2017 06:11, Sergey Bronnikov wrote: > > On 08:38 Thu 16 Mar , Thomas Huth wrote: > >> On 15.03.2017 11:25, Sergey Bronnikov wrote: > >>> Some operating systems installs bash executable file to other directory > >>> than /bin. So it is better to use env utility to find bash. > >> > >> Which operating systems do you have in mind here? > > > > OpenBSD > > Ok, then I'd say this patch simply does not make sense. We're talking > about kvm-unit-tests here - and KVM is pretty much Linux-only as far as > I know. according to description on the project page: "Unit tests provide KVM and virtual hardware functional testing by targeting the features through minimal implementations of their use per the hardware specification." http://www.linux-kvm.org/page/KVM-unit-tests So testsuite is applicable to any virtual machine with hardware emulation. OpenBSD has QEMU in ports and it's own hypervisor vmd(8) (http://man.openbsd.org/vmd). It would be perfect to use testsuite for regression testing of these hypervisors on OpenBSD too. Moreover my patch don't broke anything on Linux. Why not to commit it and make tests more portable? $ qemu-system-x86_64 -nodefaults -device isa-debug-exit,iobase=0xf4,iosize=0x4 -vnc none -serial stdio -kernel x86/msr.flat enabling apic PASS: IA32_SYSENTER_CS PASS: MSR_IA32_SYSENTER_ESP PASS: IA32_SYSENTER_EIP PASS: MSR_IA32_MISC_ENABLE PASS: MSR_IA32_CR_PAT PASS: MSR_FS_BASE PASS: MSR_GS_BASE PASS: MSR_KERNEL_GS_BASE PASS: MSR_EFER PASS: MSR_LSTAR PASS: MSR_CSTAR PASS: MSR_SYSCALL_MASK PASS: MSR_*STAR eager loading SUMMARY: 13 tests $ uname -a OpenBSD openbsd.example.com 6.0 GENERIC.MP#2319 amd64 $ > Every Linux distro that I've seen so far provides /bin/bash, so > I don't think we've got to change this. > > Thomas
