Re: [PATCH 14/17] tools/kvm_stat: add option '--guest'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20.02.2017 16:42, Stefan Raspl wrote:
> Add a new option '-g'/'--guest' to select a particular process by providing
> the QEMU guest name.
> Notes:
> - The logic to figure out the pid corresponding to the guest name might look
>   scary, but works pretty reliably in practice; in the unlikely event that it
>   returns add'l flukes, it will bail out and hint at using '-p' instead, no
>   harm done.
> - Mixing '-g' and '-p' is possible, and the final instance specified on the
>   command line is the significant one. This is consistent with current
>   behavior for '-p' which, if specified multiple times, also regards the final
>   instance as the significant one.
> 
> Signed-off-by: Stefan Raspl <raspl@xxxxxxxxxxxxxxxxxx>

This is really helpful, no more extra terminals for searching guest pids
anymore. And I hope qemu will not change the name passing for a very
long time, I want to avoid having to find solutions to such terrible
string parsing problems again.

Reviewed-by: Janosch Frank <frankja@xxxxxxxxxxxxxxxxxx>

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux