Re: [PATCH 04/17] tools/kvm_stat: fix misc glitches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/03/2017 10:42, Stefan Raspl wrote:
>>> Ah, sorry, missed the first chunk: That was to eliminate unused
>>> variable 'libc'.
>> It's not unused, it's used on the following line. :)
> Sorry, don't want to get annoying: Yeah, right, so I was eliminating
> that variable - do you want me to remove the chunk from the patch?

Yes, please.

>>> As for the "3.": I noticed through pylint, PEP8 is fine. Seemed
>>> valid to me, but in the grand scheme of things it certainly doesn't
>>> matter (and wasn't aware it becomes moot in Python 3), so I'd take
>>> it out if you want.
>> I think it's a valid complaint with Python 2 division.  If pylint
>> complaints even with "from __future__ import division", it would be a
>> pylint bug in my opinion.
>>
>> Maybe it's just me... I wouldn't have complained about "3.0" for example. :)
> Tried the import, pylint still complains :O
> So: Just switch to 3.0 here and in 07/17, and repost?

And this too.

Thanks,

Paolo



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux