On 09.03.2017 17:51, Paolo Bonzini wrote:
>
>
> On 20/02/2017 16:41, Stefan Raspl wrote:
>> @@ -339,8 +338,7 @@ def get_filters():
>> filters['kvm_exit'] = ('exit_reason', ARCH.exit_reasons)
>> return filters
>>
>> -libc = ctypes.CDLL('libc.so.6', use_errno=True)
>> -syscall = libc.syscall
>> +syscall = ctypes.CDLL('libc.so.6', use_errno=True).syscall
>>
>> class perf_event_attr(ctypes.Structure):
>> """Struct that holds the necessary data to set up a trace event.
>> @@ -950,11 +948,10 @@ class Tui(object):
>> while True:
>> self.refresh(sleeptime)
>> curses.halfdelay(int(sleeptime * 10))
>> - sleeptime = 3
>> + sleeptime = 3.
>> try:
>> char = self.screen.getkey()
>> if char == 'x':
>> - self.drilldown = not self.drilldown
>> self.update_drilldown()
>> if char == 'q':
>> break
>
> I'm not sure I understand the point of these; the rest is fine.
'sleeptime' starts out as a float (sleeptime = 0.25), but is here
re-defined to an int - so we make it float all the way.
The variable 'drilldown' is never used, so we remove its
initialization in __init__() and the sole place where it is ever
used, which is the line above.
Ciao,
Stefan
