On 09.03.2017 18:00, Paolo Bonzini wrote: > > > On 20/02/2017 16:41, Stefan Raspl wrote: >> Assortment of various fixes and improvements for the kvm_stat utility. >> Patches 1-5 are bugfixes. >> Patch 6 provides full PEP8 compliance by inserting the required empty >> lines. It is included as an extra for easy disposal, since that kind of >> patch might be a bit controversial. >> There are some subtle aspects regarding patch 7, as its effects might >> differ per platform. However, I didn't notice any negative effects, only >> improvements. >> Patch 8 is a simple doc update. >> Patches 9-13 provide usability improvements. >> Patches 14-17 add new features. >> >> Signed-off-by: Stefan Raspl <raspl@xxxxxxxxxxxxxxxxxx> > > Really nice -- just two very small comments. > > The hard-coded knowledge of QEMU is not the nicest thing (after all > kvm_stat is part of the Linux repository), but it is useful so I'm not > going to complain too loudly. Thx for the credit :) Have to admit that I totally missed the QEMU-only aspect. Still, if somebody is running something else, he'll get no result/a proper hint, so we should be fine. Ciao, Stefan
