Re: [PATCH 00/17] tools/kvm_stat: Misc Patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 20/02/2017 16:41, Stefan Raspl wrote:
> Assortment of various fixes and improvements for the kvm_stat utility.
> Patches 1-5 are bugfixes.
> Patch 6 provides full PEP8 compliance by inserting the required empty
> lines. It is included as an extra for easy disposal, since that kind of
> patch might be a bit controversial.
> There are some subtle aspects regarding patch 7, as its effects might
> differ per platform. However, I didn't notice any negative effects, only
> improvements.
> Patch 8 is a simple doc update.
> Patches 9-13 provide usability improvements.
> Patches 14-17 add new features.
> 
> Signed-off-by: Stefan Raspl <raspl@xxxxxxxxxxxxxxxxxx>

Really nice -- just two very small comments.

The hard-coded knowledge of QEMU is not the nicest thing (after all
kvm_stat is part of the Linux repository), but it is useful so I'm not
going to complain too loudly.

Paolo



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux