On 10/01/2017 06:09, Peter Xu wrote: >> Was wondering if FULL/SPLIT would be a better naming. However I also >> find irqchip_kernel() vs irqchip_in_kernel() slightly confusing. > Me too. Since we have kvm_irqchip_mode enum above, how about renaming > irqchip_{kernel|split}() into irqchip_mode_{kernel|split}()? > > Sorry for such a late comment... No problem, it can be done on top. Another thing to do is to make irqchip_in_kernel check mode != NONE. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html