Hi Joerg, On 06/01/2017 12:00, Joerg Roedel wrote: > On Thu, Jan 05, 2017 at 07:04:35PM +0000, Eric Auger wrote: >> + list_for_each_entry_safe(region, next, &group_resv_regions, list) { >> + str += sprintf(str, "0x%016llx 0x%016llx\n", >> + (long long int)region->start, >> + (long long int)(region->start + >> + region->length - 1)); >> + kfree(region); >> + } > > I think it also makes sense to report the type of the reserved region. What is the best practice in that case? Shall we put the type enum values as strings such as: - direct - nomap - msi and document that in Documentation/ABI/testing/sysfs-kernel-iommu_groups Thanks Eric > > > > Joerg > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html