On Thu, Jan 05, 2017 at 07:04:29PM +0000, Eric Auger wrote: > struct iommu_dma_cookie { > - struct iova_domain iovad; > - struct list_head msi_page_list; > - spinlock_t msi_lock; > + union { > + struct iova_domain iovad; > + dma_addr_t msi_iova; > + }; > + struct list_head msi_page_list; > + spinlock_t msi_lock; > + enum iommu_dma_cookie_type type; Please move the type to the beginning of the struct and add a comment how the type relates to the union. Joerg -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html