Re: [PATCH kvm-unit-tests 3/3] report: move blank line to better side of SUMMARY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 22/12/2016 11:53, Andrew Jones wrote:
>>      summary=$(eval $cmdline 2> >(RUNTIME_log_stderr) \
>>                               > >(tee >(RUNTIME_log_stdout $kernel) | extract_summary))
>>      ret=$?
>> +    [ "$STANDALONE" != "yes" ] && echo > >(RUNTIME_log_stdout $kernel)
> Hmm, even though this works, because of how we define RUNTIME_log_stdout
> (eventually using '>> test.log'), I should have used '>>' here as well
> for correctness.

I think it's okay, you're effectively writing to a pipe and the pipe is
opened by this echo invocation.  If you do a strace you can see that
it's basically

	echo | RUNTIME_log_stdout

Here:

    pipe([3, 4])          = 0
    fcntl(63, F_GETFD)    = -1 EBADF (Bad file descriptor)
    dup2(4, 63)           = 63
    close(4)              = 0

Thanks,

Paolo

> Paolo,
> 
> Assuming we want to merge this patch, will you fix it up on commit? Or
> should I send a v2?
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux