On Mon, Dec 19, 2016 at 05:23:05PM +0100, Andrew Jones wrote:
> Currently test.log gets output of the form
>
> test1-command-line
> test1-output
>
> SUMMARY:
> test2-command-line
> test2-output
>
> SUMMARY:
> test3-command-line
> ...
>
> Having a blank line before SUMMARY, and not after, it makes it
> tough to group lines by eye. Change it to
>
> test1-command-line
> test1-output
> SUMMARY:
>
> test2-command-line
> test2-output
> SUMMARY:
>
> test3-command-line
> ...
>
> The empty line is moved from report_summary to runtime in order
> to remove it altogether when running tests individually or as a
> standalone.
>
> Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx>
> ---
> scripts/runtime.bash | 1 +
> lib/report.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
> index 11a40a92183a..9c1bc3b3b3fe 100644
> --- a/scripts/runtime.bash
> +++ b/scripts/runtime.bash
> @@ -108,6 +108,7 @@ function run()
> summary=$(eval $cmdline 2> >(RUNTIME_log_stderr) \
> > >(tee >(RUNTIME_log_stdout $kernel) | extract_summary))
> ret=$?
> + [ "$STANDALONE" != "yes" ] && echo > >(RUNTIME_log_stdout $kernel)
Hmm, even though this works, because of how we define RUNTIME_log_stdout
(eventually using '>> test.log'), I should have used '>>' here as well
for correctness.
Paolo,
Assuming we want to merge this patch, will you fix it up on commit? Or
should I send a v2?
Thanks,
drew
>
> if [ $ret -eq 0 ]; then
> echo "`PASS` $1 $summary"
> diff --git a/lib/report.c b/lib/report.c
> index fc0ef494f412..e24e81382f9e 100644
> --- a/lib/report.c
> +++ b/lib/report.c
> @@ -109,7 +109,7 @@ int report_summary(void)
> {
> spin_lock(&lock);
>
> - printf("\nSUMMARY: %d tests", tests);
> + printf("SUMMARY: %d tests", tests);
> if (failures)
> printf(", %d unexpected failures", failures);
> if (xfailures)
> --
> 2.9.3
>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
