----- Original Message ----- > From: "Pan Xinhui" <xinhui@xxxxxxxxxxxxxxxxxx> > To: "Linus Torvalds" <torvalds@xxxxxxxxxxxxxxxxxxxx>, "Paolo Bonzini" <pbonzini@xxxxxxxxxx> > Cc: "Linux Kernel Mailing List" <linux-kernel@xxxxxxxxxxxxxxx>, "Radim Krčmář" <rkrcmar@xxxxxxxxxx>, "KVM list" > <kvm@xxxxxxxxxxxxxxx> > Sent: Saturday, December 17, 2016 4:09:16 AM > Subject: Re: [GIT PULL] KVM fixes for 4.10 merge window > > > > 在 2016/12/17 03:42, Linus Torvalds 写道: > > On Fri, Dec 16, 2016 at 8:57 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > >> > >> git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus > > > > This piece-of-shit branch has obviously never been even compile-tested: > > > > arch/x86/kernel/kvm.c: In function ‘__kvm_vcpu_is_preempted’: > > arch/x86/kernel/kvm.c:596:14: error: ‘struct kvm_steal_time’ has no > > member named ‘preempted’ > > > hi, Linus > oh, my bad also. I introduce this struct member and use it in same patch. > Better to separate tem into two patches. I make one fix patch below. sorry > again. Hi Xinhui, don't worry it's purely my fault. :) > I have known where is th problem, I think if we can set this ->preempted > later after preempted_enable() > or just introduce something like write_guest_nosleep (per cpu memory section > in guest, so there is no page_fault or any other cannot sleep problems)? Yes there is already kvm_read_guest_inatomic, we can add an equivalent one for writes. It will be for 4.11 anyway, so there's time. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
