> On Fri, Dec 16, 2016 at 8:57 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > > > git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus > > This piece-of-shit branch has obviously never been even compile-tested: > > arch/x86/kernel/kvm.c: In function ‘__kvm_vcpu_is_preempted’: > arch/x86/kernel/kvm.c:596:14: error: ‘struct kvm_steal_time’ has no > member named ‘preempted’ > > where commit b94c3698b4b0 ("Revert "x86/kvm: Support the vCPU > preemption check"") removed the "preempted" field from struct > kvm_steal_time, but you left this in place: > > __visible bool __kvm_vcpu_is_preempted(int cpu) > { > struct kvm_steal_time *src = &per_cpu(steal_time, cpu); > > return !!src->preempted; > } > > And no, that is not a merge artifact in my tree (although that > function did come in from Ingo). That compile failure comes from your > very own branch. Yes, it does. Well, to be honest I did test this (not just compile-test it) but I didn't have KVM guest support turned on, only KVM host support. Sorry, I'll resend it and make sure I do a "make allmodconfig" in the future (and not send pull requests at 6 PM on Friday). Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html