On 14/12/2016 19:39, Brijesh Singh wrote: > > On 12/14/2016 11:23 AM, Paolo Bonzini wrote: >> >> >> On 14/12/2016 18:07, Brijesh Singh wrote: >>>> >>> >>> Since now we are going to perform multiple conditional checks before >>> concluding that its safe to use HW provided GPA. How about if we add two >>> functions "emulator_is_rep_string_op" and "emulator_is_two_mem_op" into >>> emulator.c and use these functions inside the x86.c to determine if its >>> safe to use HW provided gpa? >> >> Why not export only emulator_can_use_gpa from emulate.c? (So in the end >> leaving emulator_is_string_op in emulate.c was the right thing to do, it >> was just the test that was wrong :)). >> > > Actually, I was not sure if putting emulator_can_use_gpa() in emulate.c > was right thing - mainly because emulator.c does not deal with GPA. I > will go with your advice and put it in emulator.c, it makes easy :) > > >> The patch below is still missing the check for cross-page MMIO. Your >> reference to the BKDG only covers MMCONFIG (sometimes referred to as >> ECAM), not MMIO in general. Doing AND or OR into video memory for >> example is perfectly legal, and I'm fairly sure that some obscure legacy >> software does PUSH/POP into vram as well! >> >> > > I used your below code snippet to detect cross-page MMIO access. After > applying these changes cross-page MMIO read/write unit test is passing > just fine. I will include it in patch. Great, thanks. I hope we can include it in 4.10. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
