On 14/12/2016 18:07, Brijesh Singh wrote: >> > > Since now we are going to perform multiple conditional checks before > concluding that its safe to use HW provided GPA. How about if we add two > functions "emulator_is_rep_string_op" and "emulator_is_two_mem_op" into > emulator.c and use these functions inside the x86.c to determine if its > safe to use HW provided gpa? Why not export only emulator_can_use_gpa from emulate.c? (So in the end leaving emulator_is_string_op in emulate.c was the right thing to do, it was just the test that was wrong :)). The patch below is still missing the check for cross-page MMIO. Your reference to the BKDG only covers MMCONFIG (sometimes referred to as ECAM), not MMIO in general. Doing AND or OR into video memory for example is perfectly legal, and I'm fairly sure that some obscure legacy software does PUSH/POP into vram as well! Thanks, Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
