Re: [PATCH v2 4/5] kvm: x86: mmu: Lockless access tracking for Intel CPUs without EPT A bits.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, December 02, 2016 03:33:38 AM Paolo Bonzini wrote:
> 
> I think it's correct _not_ to call kvm_set_pfn_accessed, because the
> clear_flush_young MMU notifier is called when you want to clear the
> accessed bit.  So your patch would be fixing a bug in the case where
> EPT A/D bits aren't available.
 
Thanks for the clarification. The existing patch actually didn’t fix it because mmu_spte_update calls kvm_set_pfn_accessed when switching to an acc-track PTE (or clearing the A bit). But I guess I can introduce a parameter to avoid doing that when mmu_spte_update is being called from mmu_spte_age.

Thanks,
Junaid

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux